Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer the shape only if chunks is not supplied by the caller of to_zarr #10561

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

bartbroere
Copy link
Contributor

@bartbroere bartbroere commented Oct 16, 2023

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@github-actions github-actions bot added the array label Oct 16, 2023
@bartbroere bartbroere changed the title Infer the shape only if chunks is not supplied Infer the shape only if chunks is not supplied by the caller of to_zarr Oct 16, 2023
@github-actions github-actions bot added the needs attention It's been a while since this was pushed on. Needs attention from the owner or a maintainer. label Dec 25, 2023
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 16m 58s ⏱️ - 1m 21s
 13 104 tests ±0   12 175 ✅ ±0     929 💤 ±0  0 ❌ ±0 
162 287 runs  ±0  145 759 ✅ +2  16 528 💤  - 2  0 ❌ ±0 

Results for commit 4265030. ± Comparison against base commit 0496681.

Copy link
Collaborator

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
array needs attention It's been a while since this was pushed on. Needs attention from the owner or a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dask.array.to_zarr() does not parse for chunks kwarg
3 participants