Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates needed for compatibility with nfts in the tui #1833

Merged
merged 11 commits into from May 9, 2024

Conversation

pauldelucia
Copy link
Member

@pauldelucia pauldelucia commented Apr 29, 2024

Issue being fixed or feature implemented

Some files of the SDK were not public so they couldn't be accessed from the TUI where they are needed.

I also derived Serialize and Deserialize for the Index struct because I need to serialize the data contract indexes in order to display them in the TUI.

I also changed an error message to display more info, and made it a String instead of a str. The rest of the error messages should be changed to a String as well in a separate PR (#1839)

What was done?

See above.

How Has This Been Tested?

Works in the TUI and passes tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title feat: make sdk transition files public chore(sdk): make sdk transition files public Apr 30, 2024
@qwizzie
Copy link

qwizzie commented May 1, 2024

Does this affect Dash Platform stability testing (iaw your guide), through use of Platform TUI ? Should we wait on the merger of this pull request ?

Edit : or is the relevant part possibly affecting Platform stability testing already merged through pull request 1832 ?

@pauldelucia
Copy link
Member Author

Does this affect Dash Platform stability testing (iaw your guide), through use of Platform TUI ? Should we wait on the merger of this pull request ?

Edit : or is the relevant part possibly affecting Platform stability testing already merged through pull request 1832 ?

@qwizzie this will just allow for the NFT-related state transitions to be used in the TUI, both in the strategy tests once I add them, and also just in the Contracts screen.

@pauldelucia pauldelucia changed the title chore(sdk): make sdk transition files public chore(sdk): updates needed for compatibility with nfts in the tui May 9, 2024
@pauldelucia pauldelucia changed the title chore(sdk): updates needed for compatibility with nfts in the tui chore: updates needed for compatibility with nfts in the tui May 9, 2024
@pauldelucia pauldelucia merged commit 26abf50 into v1.0-dev May 9, 2024
65 checks passed
@pauldelucia pauldelucia deleted the feat/public-document-price-update branch May 9, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants