fix: should always use manually-installed llvm, regardless of platform #1717
+6
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This use of command prefixes is redundant since
command -v clang
is just looking upclang
in the user'sPATH
- which is what typing theclang
command will do already, except in situations where there's a shell function or alias calledclang
(which is not the case on macOS or Linux).Also, clang must be installed via the official tarball regardless of macOS or Linux.
Issue being fixed or feature implemented
Just documenting behavior.
What was done?
Documented that llvm must be installed manually (regardless of mac vs linux).
Removed redundant (and potentially confusing) use of
command -v
to define a command that's already in the user'sPATH
.How Has This Been Tested?
clang
won't build these tools, but the official version will.See
v1.0-dev
(the current working branch) fails to build from source #1712.(tested on a fresh install via UTM virtual machine)
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only