Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should always use manually-installed llvm, regardless of platform #1717

Open
wants to merge 1 commit into
base: v1.0-dev
Choose a base branch
from

Conversation

coolaj86
Copy link

@coolaj86 coolaj86 commented Feb 26, 2024

This use of command prefixes is redundant since command -v clang is just looking up clang in the user's PATH - which is what typing the clang command will do already, except in situations where there's a shell function or alias called clang (which is not the case on macOS or Linux).

Also, clang must be installed via the official tarball regardless of macOS or Linux.

Issue being fixed or feature implemented

Just documenting behavior.

What was done?

Documented that llvm must be installed manually (regardless of mac vs linux).

Removed redundant (and potentially confusing) use of command -v to define a command that's already in the user's PATH.

How Has This Been Tested?

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@coolaj86
Copy link
Author

I finished testing on macOS to confirm that the AR and CC variables are NOT necessary (no xcode magic alias trickery).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant