feat(drive-abci): support consensus params updates #1713
+7,824
−10,617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feat/drive/read-only-thread
Handle query and check tx in blocked thread pool. Spawn an independent thread with max priority for consensus
lklimek
force-pushed
the
feat/consensus-params-updates
branch
from
9de809c
to
b3e2991
Compare
QuantumExplorer
requested changes
Feb 26, 2024
| /// * `Err(io::Error)` - If there was an error reading the file | ||
| /// | ||
| // TODO: Move this to correct place | ||
| pub(super) fn get_consensus_params_update( |
There was a problem hiding this comment.
This needs to be versioned, and it's own file.
Comment on lines
+226
to
+230
| consensus_param_updates: get_consensus_params_update( | ||
| &app.platform().config.abci.consensus_params_dir, | ||
| request.height, | ||
| ) | ||
| .map_err(|e| Error::Abci(AbciError::ConsensusParams(e.to_string())))?, |
There was a problem hiding this comment.
This can not work, because it would require the entire network to update on the same block. Something that is possible for a devnet, but not in a real network. Consensus params imo should be versioned, and can only change if the network votes for it in consensus.
…and refactor/fix query tests
…o feat/drive/read-only-thread # Conflicts: # packages/rs-drive-abci/src/server.rs
lklimek
force-pushed
the
feat/consensus-params-updates
branch
from
736d1d8
to
7167d4e
Compare
…sensus-params-updates
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
For tuning of ABCI consensus params, we need a way to specify consensus params updates in real time, without modifying or even restarting the Drive.
What was done?
Added an option to propose consensus params updates, based on content of some directory on disk.
Added option consensus_params_dir to ABCI configuration.
TODO: Support in ProcessProposal.
How Has This Been Tested?
Not tested yet.
Breaking Changes
Checklist:
For repository code-owners and collaborators only