refactor(drive-abci): clarify error message #1700
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolaj86
force-pushed
the
ref-version-mismatch
branch
2 times, most recently
from
298d43c
to
c9e6404
Compare
coolaj86
changed the title
coolaj86
force-pushed
the
ref-version-mismatch
branch
2 times, most recently
from
6b484c0
to
0c242da
Compare
coolaj86
force-pushed
the
ref-version-mismatch
branch
from
0c242da
to
57ebbd6
Compare
|
I see that the message was updated, however the "our" is still ambiguous - since this message will be seen from a client and it will not be obvious that "our" refers to the server, not the client. I still move that we should use the most clear language possible to avoid confusion. "Your", "our", "my", "their", etc language should not be used in client/server communication, but rather "client" and "server" or other precise language.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this error shows up in the tenderdash logs, the use of "our" is confusing.
This clarifies which version each program is showing.
For repository code-owners and collaborators only