ref(wasm-dpp): simplify scripts/build-js.sh for readability and testability #1697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to copy/paste to test or run locally.
This had a bunch of variables for things that were actually constant strings with no variability, which made it look much more complex, and much more difficult to understand the full context of.
This simplifies it to only use variables where the output is non-constant or used many times.
Issue being fixed or feature implemented
build-wasm.sh
, assumingcargo build was run
)shellcheck
&shfmt
What was done?
This was a bit over-variable-ified for strings that were actually constant and not used more than twice.
How Has This Been Tested?
I just ran it the normal way.
Checklist:
For repository code-owners and collaborators only