Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashmate): handle docker pull error on images update #1685

Merged
merged 8 commits into from May 6, 2024

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Jan 30, 2024

Issue being fixed or feature implemented

#1684

Handle errors from the docker when doing dashmate update

What was done?

  • Removed reject from the promise in updateNodeFactory
  • Added a unit test
  • Added error update status in the dashmate update command

How Has This Been Tested?

Manually + unit test

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic added this to the v1.0.0 milestone Mar 14, 2024
@pshenmic pshenmic marked this pull request as ready for review March 14, 2024 12:08
@pshenmic pshenmic merged commit 8073c3f into v1.0-dev May 6, 2024
21 checks passed
@pshenmic pshenmic deleted the fix/dashmate-update-try-catch branch May 6, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants