Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: prebuild rocksdb #1610

Open
wants to merge 1 commit into
base: v1.0-dev
Choose a base branch
from
Open

build: prebuild rocksdb #1610

wants to merge 1 commit into from

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Nov 29, 2023

Issue being fixed or feature implemented

Build of rocksdb crate takes quite much time.
Majority of this time is due to build of rocksdb C binaries.

This fact is mitigated by our awesome caching engine, but it's an issue when cache is invalidated.

This is also useful for local testing.

What was done?

Prebuild rocksdb binary as part of deps image.

How Has This Been Tested?

Run gh actions

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool! Don't we need to add this to other rust builds in CI?

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building images take much more than before, isn't it? https://github.com/dashpay/platform/actions/runs/7029605378?pr=1610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants