feat(sdk): testing framework for puts (state transitions) in rs-sdk #1569
+6,559
−1,313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit message: feat(rs-sdk): add cancellation token and refactor address watcher This commit introduces CancellationToken into the Rust SDK for graceful shutdowns. It also refactors the Address Watcher in the Subscriber module, changing its internal data structure from a BTreeMap to a Vec for storing JoinHandles of spawned tasks. In addition, the commit reexports types from dashcore-rpc crate in the core module and modifies some import statements across different modules for better code organization. The Wallet interface is updated with a new function signature for signing core chain transactions. Lastly, the commit includes changes to the test files to adapt to the new CancellationToken usage and other minor modifications. These changes enhance the maintainability of the code and allow for more controlled execution flow, especially in scenarios requiring task cancellation.
6 tasks
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
For the rs-sdk testing, we assume that each feature must have relevant test implemented.
Current rs-sdk test framework doesn't support testing of Puts (what includes state transitions).
What was done?
In this PR, we define a
Wallettrait that provides access to wallet features.On top of that, we include improvements to ContextProvider (formerly known as QuorumInfoProvider).
How Has This Been Tested?
Integrated with rs-platform-explorer (not pushed) - it builds. :)
Breaking Changes
Checklist:
For repository code-owners and collaborators only