refactor: format source code using nightly rustfmt #1567
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklimek
force-pushed
the
refactor-rustfmt
branch
from
0a49287
to
fd3ad57
Compare
lklimek
force-pushed
the
refactor-rustfmt
branch
from
fd3ad57
to
cbcbc8c
Compare
shumkov
reviewed
Nov 22, 2023
| cache: false | ||
|
|
||
| - name: Check formatting | ||
| run: exit `cargo fmt --check --package=${{ inputs.package }} | wc -l` | ||
| run: exit `cargo +nightly fmt --check --package=${{ inputs.package }} | wc -l` |
There was a problem hiding this comment.
How is it going to work since we are still on stable channel and my IDE formats changed files automatically? I can't define a toolbox for formating there. Shall we just wait until this feature becomes stable?
lklimek
force-pushed
the
refactor-rustfmt
branch
from
06c819c
to
7b45ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We need to unify code formatting.
What was done?
This PR adds
.rustfmt.tomlfile to the repo that defines formatting of Rust code.cargo +nightly fmtHow Has This Been Tested?
Breaking Changes
Will cause tons of conflicts.
Checklist:
For repository code-owners and collaborators only