New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add getTxChainLocks to RPC list and array to types #64

Open

coolaj86 wants to merge 1 commit into dashpay:master from dashhive:feat-gettxchainlocks

Contributor

coolaj86 commented Mar 13, 2024 •

edited

It's important to note that this takes an anonymous array as the parameter, not an object with a named key like other RPC calls in the library.

- rpc.getTxChainLocks({ txids: [ "xxxx..." ] });
+ rpc.getTxChainLocks([ "xxxx..." ]);

Re: #63

These May NOT be the Droids You're Looking For

InstantSend Lock (a.k.a. ISLock, LLMQ Lock) is NOT ChainLock.

Instead see the isInstantSendLock field from getRawTransaction.

Monkey Patch

This can be monkey-patched, for those waiting for this PR to get pulled in:

var RpcClient require('@dashevo/dashd-rpc');

RpcClient.callspec.getTxChainLocks = 'obj';

Note: this uses obj rather than array because the types can't be monkey-patched and the difference between the two is only semantic here.


          feat: add getTxChainLocks to RPC list and array to types

6bfdc6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment