New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DH 7: ref: nix async lib in the simplest way #61
Open
coolaj86
wants to merge
10
commits into
dashpay:master
Choose a base branch
from
dashhive:ref-nix-async-lib-simple
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolaj86
force-pushed
the
ref-nix-async-lib-simple
branch
2 times, most recently
from
June 15, 2023 23:31
1f855ba
to
29d8fe7
Compare
coolaj86
force-pushed
the
ref-nix-async-lib-simple
branch
from
April 12, 2024 22:38
29d8fe7
to
7b00806
Compare
coolaj86
force-pushed
the
ref-nix-async-lib-simple
branch
from
April 12, 2024 22:40
7b00806
to
7fea699
Compare
coolaj86
changed the title
ref: nix async lib in the simplest way
DH 7: ref: nix async lib in the simplest way
Apr 12, 2024
coolaj86
changed the title
DH 7: ref: nix async lib in the simplest way
DH 7(a): ref: nix async lib in the simplest way
Apr 12, 2024
coolaj86
changed the title
DH 7(a): ref: nix async lib in the simplest way
DH 7: ref: nix async lib in the simplest way
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on other PRs now, so the relevant commit is just 7fea699.
This replaces
async
withPromise
in the simplest way possible.Much of the time task pools are used with such a high number that they actually cause thrashing and decrease performance.
My assumption that the magic number of 16 tasks probably wasn't tested, but just chosen at random and this would actually be more performant queuing single tasks in a row anyway.
Since it's being called on a batch (which already contains some number of requests), I think that even more.
Built on #60 just look at b94b291 for actual code changes.
Essentially: