backport: Merge bitcoin#21718, 21759, 21872

[vijaydasmp]

bitcoin backports

[github-actions]

This pull request has conflicts, please rebase.

[UdjinM6]

21759: missing changes

Suggested change

	const bool m_include_partial_groups{false}; //! Include partial destination groups when avoid_reuse and there are full groups
	/** When avoid_reuse=true and there are full groups (OUTPUT_GROUP_MAX_ENTRIES), whether or not to use any partial groups.*/
	const bool m_include_partial_groups{false};

[UdjinM6]

21759:

Suggested change

	CFeeRate m_effective_feerate{0};
	/** The target feerate of the transaction we're trying to build. */
	CFeeRate m_effective_feerate{0};

[UdjinM6]

21759:

Suggested change

	CFeeRate m_long_term_feerate{0};
	/** The feerate for spending a created change output eventually (i.e. not urgently, and thus at
	* a lower feerate). Calculated using long term fee estimate. This is used to decide whether
	* it could be economical to create a change output. */
	CFeeRate m_long_term_feerate{0};

[UdjinM6]

21759:

Suggested change

	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(1, 6, 0), vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used)) return true;
	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(1, 1, 0), vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used)) return true;
	// Fall back to using zero confirmation change (but with as few ancestors in the mempool as
	// possible) if we cannot fund the transaction otherwise. We never spend unconfirmed
	// outputs received from other wallets.
	if (m_spend_zero_conf_change) {
	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(0, 1, 2), vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used)) return true;
	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(0, 1, std::min((size_t)4, max_ancestors/3), std::min((size_t)4, max_descendants/3)),
	vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used)) {
	return true;
	}
	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(0, 1, max_ancestors/2, max_descendants/2),
	vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used)) {
	return true;
	}
	// If partial groups are allowed, relax the requirement of spending OutputGroups (groups
	// of UTXOs sent to the same address, which are obviously controlled by a single wallet)
	// in their entirety.
	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(0, 1, max_ancestors-1, max_descendants-1, true /* include_partial_groups */),
	vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used)) {
	return true;
	}
	// Try with unlimited ancestors/descendants. The transaction will still need to meet
	// mempool ancestor/descendant policy to be accepted to mempool and broadcasted, but
	// OutputGroups use heuristics that may overestimate ancestor/descendant counts.
	if (!fRejectLongChains && SelectCoinsMinConf(value_to_select,
	CoinEligibilityFilter(0, 1, std::numeric_limits<uint64_t>::max(), std::numeric_limits<uint64_t>::max(), true /* include_partial_groups */),
	vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used)) {
	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(1, 6, 0), vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used, nCoinType)) return true;
	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(1, 1, 0), vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used, nCoinType)) return true;
	// Fall back to using zero confirmation change (but with as few ancestors in the mempool as
	// possible) if we cannot fund the transaction otherwise. We never spend unconfirmed
	// outputs received from other wallets.
	if (m_spend_zero_conf_change) {
	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(0, 1, 2), vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used, nCoinType)) return true;
	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(0, 1, std::min((size_t)4, max_ancestors/3), std::min((size_t)4, max_descendants/3)),
	vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used, nCoinType)) {
	return true;
	}
	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(0, 1, max_ancestors/2, max_descendants/2),
	vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used, nCoinType)) {
	return true;
	}
	// If partial groups are allowed, relax the requirement of spending OutputGroups (groups
	// of UTXOs sent to the same address, which are obviously controlled by a single wallet)
	// in their entirety.
	if (SelectCoinsMinConf(value_to_select, CoinEligibilityFilter(0, 1, max_ancestors-1, max_descendants-1, true /* include_partial_groups */),
	vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used, nCoinType)) {
	return true;
	}
	// Try with unlimited ancestors/descendants. The transaction will still need to meet
	// mempool ancestor/descendant policy to be accepted to mempool and broadcasted, but
	// OutputGroups use heuristics that may overestimate ancestor/descendant counts.
	if (!fRejectLongChains && SelectCoinsMinConf(value_to_select,
	CoinEligibilityFilter(0, 1, std::numeric_limits<uint64_t>::max(), std::numeric_limits<uint64_t>::max(), true /* include_partial_groups */),
	vCoins, setCoinsRet, nValueRet, coin_selection_params, bnb_used, nCoinType)) {

[UdjinM6]

21759:

Suggested change

	bool m_avoid_partial_spends = false;
	/** When true, always spend all (up to OUTPUT_GROUP_MAX_ENTRIES) or none of the outputs
	* associated with the same address. This helps reduce privacy leaks resulting from address
	* reuse. Dust outputs are not eligible to be added to output groups and thus not considered. */
	bool m_avoid_partial_spends = false;