Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simply RecursiveMutex -> Mutex #5955

Merged
merged 1 commit into from
Mar 25, 2024
Merged

refactor: simply RecursiveMutex -> Mutex #5955

merged 1 commit into from
Mar 25, 2024

Conversation

PastaPastaPasta
Copy link
Member

What was done?

This PR is a simpler version of #5954; it is simply a recursiveMutex -> Mutex PR; as I think some of the scope minimization in the other PR introduced test failures (appears there are undocumented mutex dependancies)

How Has This Been Tested?

CI TBD

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PastaPastaPasta PastaPastaPasta changed the title refacotor: simply RecursiveMutex -> Mutex refactor: simply RecursiveMutex -> Mutex Mar 25, 2024
knst
knst approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a09e260

UdjinM6
UdjinM6 approved these changes Mar 25, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit 9201529 into dashpay:develop Mar 25, 2024
8 checks passed
@PastaPastaPasta PastaPastaPasta deleted the refac-recursive-mutex-2 branch March 25, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knst knst knst approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PastaPastaPasta @knst @UdjinM6