forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: auto generation EHF and spork+EHF activation for MN_RR (#5597)
Implementation EHF mechanism, part 4. Previous changes are: - #4577 - #5505 - #5469 ## Issue being fixed or feature implemented Currently MN_RR is activated automatically by soft-fork activation after v20 is activated. It is not flexible enough, because platform may not be released by that time yet or in opposite it can be too long to wait. Also, any signal of EHF requires manual actions from MN owners to sign EHF signal - it is automated here. ## What was done? New spork `SPORK_24_MN_RR_READY`; new EHF manager that sign EHF signals semi-automatically without manual actions; and send transaction with EHF signal when signal is signed to network. Updated rpc `getblockchaininfo` to return information about of EHF activated forks. Fixed function `IsTxSafeForMining` in chainlock's handler to skip transactions without inputs (empty `vin`). ## How Has This Been Tested? Run unit/functional tests. Some tests have been updated due to new way of MN_RR activation: `feature_asset_locks.py`, `feature_mnehf.py`, `feature_llmq_evo.py` and unit test `block_reward_reallocation_tests`. ## Breaking Changes New way of MN_RR activation. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ --------- Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
- Loading branch information
3 people
committed
Oct 18, 2023
1 parent
cecf63e
commit 63ed462
Showing
18 changed files
with
304 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| // Copyright (c) 2023 The Dash Core developers | ||
| // Distributed under the MIT/X11 software license, see the accompanying | ||
| // file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
|
||
| #include <llmq/ehf_signals.h> | ||
| #include <llmq/utils.h> | ||
| #include <llmq/quorums.h> | ||
| #include <llmq/signing_shares.h> | ||
| #include <llmq/commitment.h> | ||
|
|
||
|
|
||
| #include <evo/mnhftx.h> | ||
| #include <evo/specialtx.h> | ||
|
|
||
| #include <index/txindex.h> // g_txindex | ||
|
|
||
| #include <primitives/transaction.h> | ||
| #include <spork.h> | ||
| #include <txmempool.h> | ||
| #include <validation.h> | ||
|
|
||
| namespace llmq { | ||
|
|
||
|
|
||
| CEHFSignalsHandler::CEHFSignalsHandler(CChainState& chainstate, CConnman& connman, | ||
| CSigningManager& sigman, CSigSharesManager& shareman, | ||
| const CSporkManager& sporkman, const CQuorumManager& qman, CTxMemPool& mempool) : | ||
| chainstate(chainstate), | ||
| connman(connman), | ||
| sigman(sigman), | ||
| shareman(shareman), | ||
| sporkman(sporkman), | ||
| qman(qman), | ||
| mempool(mempool) | ||
| { | ||
| sigman.RegisterRecoveredSigsListener(this); | ||
| } | ||
|
|
||
|
|
||
| CEHFSignalsHandler::~CEHFSignalsHandler() | ||
| { | ||
| sigman.UnregisterRecoveredSigsListener(this); | ||
| } | ||
|
|
||
| void CEHFSignalsHandler::UpdatedBlockTip(const CBlockIndex* const pindexNew) | ||
| { | ||
| if (!fMasternodeMode || !llmq::utils::IsV20Active(pindexNew) || !sporkman.IsSporkActive(SPORK_24_EHF)) { | ||
| return; | ||
| } | ||
|
|
||
| // TODO: should do this for all not-yet-signied bits | ||
| trySignEHFSignal(Params().GetConsensus().vDeployments[Consensus::DEPLOYMENT_MN_RR].bit, pindexNew); | ||
| } | ||
|
|
||
| void CEHFSignalsHandler::trySignEHFSignal(int bit, const CBlockIndex* const pindex) | ||
| { | ||
| MNHFTxPayload mnhfPayload; | ||
| mnhfPayload.signal.versionBit = bit; | ||
| const uint256 requestId = mnhfPayload.GetRequestId(); | ||
|
|
||
| LogPrintf("CEHFSignalsHandler::trySignEHFSignal: bit=%d at height=%d id=%s\n", bit, pindex->nHeight, requestId.ToString()); | ||
|
|
||
| const Consensus::LLMQType& llmqType = Params().GetConsensus().llmqTypeMnhf; | ||
| const auto& llmq_params_opt = llmq::GetLLMQParams(llmqType); | ||
| if (!llmq_params_opt.has_value()) { | ||
| return; | ||
| } | ||
| if (sigman.HasRecoveredSigForId(llmqType, requestId)) { | ||
| LOCK(cs); | ||
| ids.insert(requestId); | ||
|
|
||
| // no need to sign same message one more time | ||
| return; | ||
| } | ||
|
|
||
| const auto quorum = sigman.SelectQuorumForSigning(llmq_params_opt.value(), qman, requestId); | ||
| if (!quorum) { | ||
| LogPrintf("CEHFSignalsHandler::trySignEHFSignal no quorum for id=%s\n", requestId.ToString()); | ||
| return; | ||
| } | ||
|
|
||
| mnhfPayload.signal.quorumHash = quorum->qc->quorumHash; | ||
| const uint256 msgHash = mnhfPayload.PrepareTx().GetHash(); | ||
|
|
||
| { | ||
| LOCK(cs); | ||
| ids.insert(requestId); | ||
| } | ||
| sigman.AsyncSignIfMember(llmqType, shareman, requestId, msgHash); | ||
| } | ||
|
|
||
| void CEHFSignalsHandler::HandleNewRecoveredSig(const CRecoveredSig& recoveredSig) | ||
| { | ||
| if (g_txindex) { | ||
| g_txindex->BlockUntilSyncedToCurrentChain(); | ||
| } | ||
|
|
||
| if (WITH_LOCK(cs, return ids.find(recoveredSig.getId()) == ids.end())) { | ||
| // Do nothing, it's not for this handler | ||
| return; | ||
| } | ||
|
|
||
| MNHFTxPayload mnhfPayload; | ||
| // TODO: should do this for all not-yet-signied bits | ||
| mnhfPayload.signal.versionBit = Params().GetConsensus().vDeployments[Consensus::DEPLOYMENT_MN_RR].bit; | ||
|
|
||
| const uint256 expectedId = mnhfPayload.GetRequestId(); | ||
| LogPrintf("CEHFSignalsHandler::HandleNewRecoveredSig expecting ID=%s received=%s\n", expectedId.ToString(), recoveredSig.getId().ToString()); | ||
| if (recoveredSig.getId() != mnhfPayload.GetRequestId()) { | ||
| // there's nothing interesting for CEHFSignalsHandler | ||
| LogPrintf("CEHFSignalsHandler::HandleNewRecoveredSig id is known but it's not MN_RR, expected: %s\n", mnhfPayload.GetRequestId().ToString()); | ||
| return; | ||
| } | ||
|
|
||
| mnhfPayload.signal.quorumHash = recoveredSig.getQuorumHash(); | ||
| mnhfPayload.signal.sig = recoveredSig.sig.Get(); | ||
|
|
||
| CMutableTransaction tx = mnhfPayload.PrepareTx(); | ||
|
|
||
| { | ||
| CTransactionRef tx_to_sent = MakeTransactionRef(std::move(tx)); | ||
| LogPrintf("CEHFSignalsHandler::HandleNewRecoveredSig Special EHF TX is created hash=%s\n", tx_to_sent->GetHash().ToString()); | ||
| LOCK(cs_main); | ||
| TxValidationState state; | ||
| if (AcceptToMemoryPool(chainstate, mempool, state, tx_to_sent, /* bypass_limits=*/ false, /* nAbsurdFee=*/ 0)) { | ||
| connman.RelayTransaction(*tx_to_sent); | ||
| } else { | ||
| LogPrintf("CEHFSignalsHandler::HandleNewRecoveredSig -- AcceptToMemoryPool failed: %s\n", state.ToString()); | ||
| } | ||
| } | ||
| } | ||
| } // namespace llmq |
Oops, something went wrong.