build: add new flag "--enable-optimizations" and expand scope of "--enable-debug", additional homekeeping #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvg
force-pushed
the
debug
branch
4 times, most recently
from
c097ee8
to
d477da4
Compare
|
'This PR has been flagged as stale due to no activity for over 60 |
|
LGTM
pls check 0d88e91 for more of this :) |
…erm]`
The arguments were called `disable-{tests,bench,hardening}` but the
variable they set was `use_[term]`, which could lead to an inversion.
It appears that it is expected that developers declare enablement flags
and Autotools will generate their equivalent disablement flags but there's
no text to indicate that the same will happen vice-versa.
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
This is a problem introduced by skipping architecture specific flags when building with optimizations disabled. Neither i?86 nor arm contain the number 32 in it, making number based matching unusable. But arm64 is 64-bit (though usually the recommended term is aarch64) and so we must match targets with the number 64 first before we assume anything with arm is 32-bit.
These are defined nowhere and used nowhere
kwvg
force-pushed
the
debug
branch
2 times, most recently
from
f6e6462
to
6a14049
Compare
kwvg
changed the title
Helps us avoid a situation where a compiler will report a warning instead of erroring out when testing a flag, giving `autotools` the impression they are supported when they are not, polluting the build log with "argument unused during compilation" messages.
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional information
This pull request is a result a comment which proposed a possible source for non-reproducible builds on Apple Silicon as difference in optimized code output.
While investigating further, it was realized that
bls-signatureslacks the option to enable useful debugging flags or disable optimizations (both by the compiler and from libraries).--enable-debugwill setDEBUG=1for Relic (existing behaviour), disables compiler optimization (and leaves library optimizations as-is), sets the dbginfo level to 3 and sets-ftrapv--disable-optimizationswill disable both compiler and library optimizations (by setting (CPU_)ARCHtononeand setting the backend toeasyunless overridden), does not change the dbginfo level and sets-fwrapvIf both flags are used and there are conflicts, the flags set by
--enable-debugwill take precedence (i.e. debug level will be 3 and-ftrapvwill be set)These changes are made alongside general housekeeping and consolidation of the
autoconfscript.