For logging multiple values #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
le1nux
requested changes
Aug 9, 2020
le1nux
reviewed
Aug 10, 2020
| @@ -218,9 +218,7 @@ def _merge_dictionaries(dict_1: Dict[str, List[Any]], dict_2: Dict[str, List[Any | |||
| merged[key] = merged[key][:measurement_id] + dict_2[key] + merged[key][ | |||
There was a problem hiding this comment.
if measurement_id is None, we can set it to len(merged[key]) and get rid of the else statement, right?
There was a problem hiding this comment.
I think so, the third addendum in merged[key] = merged[key][:measurement_id] + dict_2[key] + merged[key][measurement_id + len(dict_2[key]) - 1:] is a bit confusing to me though. So, is the idea with this line to rewrite the past measurements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If measurement_id is not provided, we can just append the values to the existing values. Therefore, the user can cache the metrics and log once in a while to save IO.