Color value component #34

flavens · 2020-02-24T12:47:58Z

closes #10

…ackage

…ch-swiss/knora-ui-ng-lib into wip/10-color-value-component

projects/knora-ui/src/lib/viewer/values/color-value/color-value.component.ts

…form field

…ieldControl

…er in ts

…changed

tobiasschweizer · 2020-03-09T09:19:48Z

Thanks, I will review this PR today!

tobiasschweizer

The picker thingy looks great. I have made some comments regarding the internal structure.

projects/knora-ui/src/lib/viewer/values/color-value/color-picker/color-picker.component.ts

projects/knora-ui/src/lib/viewer/values/color-value/color-value.component.ts

projects/knora-ui/src/lib/viewer/values/color-value/color-picker/color-picker.component.ts

… Refactor code accordingly.

…unit tests

projects/knora-ui/src/lib/viewer/values/color-value/color-picker/color-picker.component.ts

tobiasschweizer · 2020-03-10T16:17:47Z

@flavens Does representing color as a string in the sub component solve your issue?

projects/knora-ui/src/lib/viewer/values/color-value/color-value.component.spec.ts

projects/knora-ui/src/lib/viewer/values/color-value/color-picker/color-picker.component.ts

projects/knora-ui/src/lib/viewer/values/color-value/color-picker/color-picker.component.html

projects/knora-ui/src/lib/viewer/values/color-value/color-picker/color-picker.component.spec.ts

tobiasschweizer · 2020-03-11T08:25:17Z

I noticed the following when running npm install:

npm WARN ngx-color-picker@9.0.0 requires a peer of @angular/common@^9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-color-picker@9.0.0 requires a peer of @angular/core@^9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-color-picker@9.0.0 requires a peer of @angular/forms@^9.0.0 but none is installed. You must install peer dependencies yourself.

Is this version made for Angular 9?

tobiasschweizer · 2020-03-11T15:11:13Z

projects/knora-ui/src/lib/viewer/values/color-value/color-picker/color-picker.component.spec.ts

@@ -98,7 +99,7 @@ describe('ColorPickerComponent', () => {
    expect(testHostComponent.form.controls.colorValue.value).toEqual('');
  });

-  fit('should be disabled when the readonly input is set to true', () => {


Oh yes, that was the script searching for fit :-)

but it has been fixed in the last commit...

I know :-) I was just happy that the script actually worked ;-)

tobiasschweizer

Looks good! Thanks a lot for this!

flavens · 2020-03-11T15:25:54Z

@tobiasschweizer should I merge it now or should we wait?!?

tobiasschweizer · 2020-03-11T15:27:02Z

I think it's good to go. What should we wait for?

tobiasschweizer · 2020-03-11T15:31:40Z

and do not forget to hit the checkbox in #4 :-)

feat(values): Initialize color component

ffc3d37

flavens added the enhancement New feature or request label Feb 24, 2020

flavens self-assigned this Feb 24, 2020

Flavie L added 5 commits February 24, 2020 13:48

Merge branch 'master' into wip/10-color-value-component

c00b7d8

feat(color-value): Implement the color picker from ngx-color-picker p…

c73d00d

…ackage

Merge branch 'master' into wip/10-color-value-component

c950d54

Merge branch 'wip/10-color-value-component' of https://github.com/das…

5b545d6

…ch-swiss/knora-ui-ng-lib into wip/10-color-value-component

feat(color-value): Add label + color regex validators

b2ecfcd

flavens commented Feb 27, 2020

View reviewed changes

projects/knora-ui/src/lib/viewer/values/color-value/color-value.component.ts Outdated Show resolved Hide resolved

tobiasschweizer reviewed Feb 27, 2020

View reviewed changes

projects/knora-ui/src/lib/viewer/values/color-value/color-value.component.ts Outdated Show resolved Hide resolved

flaurens added 16 commits February 27, 2020 15:25

fix(color-value): Fix reset

689244a

feat(color-value): Add color picker component to create a custom mat-…

4811dc7

…form field

feat(color-value): Implement ControlValueAccessor and custom MatFormF…

4db7a3c

…ieldControl

feat(color-picker): Fix reset

bac7043

feat(color-value): Add mat-error tags in html files + implement match…

22701d8

…er in ts

test(color-value): Add imports and some tests

8094468

test(color-value): Add tests

0601898

test(color-value): Add more tests

c0e4a18

test(color-value): Remove deactivated tests

8933e1d

refactor(color-value): Clean up tests

ba09fa2

feat(color-value): Fix standard validator + fix edit tests

b176ffa

test(color-value): Add create value tests

b0f757e

test(color-picker): Add more tests

e14ef42

refactor(color-value): Clean up

77188fe

refactor(color-value): Clean up scss files

6103070

fix(color-value): Fix displayed error message when the value has not …

41e48ea

…changed

flavens requested a review from tobiasschweizer March 6, 2020 09:30

fix(color-picker): Add missing errorStateMatcher attribute

d467333

tobiasschweizer suggested changes Mar 9, 2020

View reviewed changes

flaurens added 2 commits March 10, 2020 15:22

feat(color-value): Replace ColorPicker object to manipulate a string.…

117e08c

… Refactor code accordingly.

fix(color): Fix the getUpdatedValue and getCreatedValue + update the …

ef9f40b

…unit tests

tobiasschweizer reviewed Mar 10, 2020

View reviewed changes

projects/knora-ui/src/lib/viewer/values/color-value/color-picker/color-picker.component.ts Show resolved Hide resolved

tobiasschweizer reviewed Mar 10, 2020

View reviewed changes

projects/knora-ui/src/lib/viewer/values/color-value/color-picker/color-picker.component.ts Outdated Show resolved Hide resolved

fix(color-value): Deal with color as string + update tests

b7c1146

tobiasschweizer suggested changes Mar 10, 2020

View reviewed changes

projects/knora-ui/src/lib/viewer/values/color-value/color-value.component.spec.ts Outdated Show resolved Hide resolved

tobiasschweizer suggested changes Mar 11, 2020

View reviewed changes

tobiasschweizer reviewed Mar 11, 2020

View reviewed changes

projects/knora-ui/src/lib/viewer/values/color-value/color-picker/color-picker.component.spec.ts Show resolved Hide resolved

flaurens added 6 commits March 11, 2020 14:32

chore: ngx-color-picker v8.2.0

e350dcb

refactor(color-picker): Clean up

6f696fa

test(color-value): Fix create value test

a398443

docs(color-picker): Add npm package link in comment

26d1f4e

test(color-picker): Fix test

56bf71b

tset(color-picker): Update test with disabled testing

490387e

flavens requested a review from tobiasschweizer March 11, 2020 14:42

tobiasschweizer reviewed Mar 11, 2020

View reviewed changes

tobiasschweizer approved these changes Mar 11, 2020

View reviewed changes

flavens merged commit e9cae9f into master Mar 11, 2020

flavens deleted the wip/10-color-value-component branch March 11, 2020 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Color value component #34

Color value component #34

flavens commented Feb 24, 2020 •

edited

tobiasschweizer commented Mar 9, 2020

tobiasschweizer left a comment

tobiasschweizer commented Mar 10, 2020

tobiasschweizer commented Mar 11, 2020

tobiasschweizer Mar 11, 2020

flavens Mar 11, 2020

tobiasschweizer Mar 11, 2020

tobiasschweizer left a comment

flavens commented Mar 11, 2020

tobiasschweizer commented Mar 11, 2020

tobiasschweizer commented Mar 11, 2020

Color value component #34

Color value component #34

Conversation

flavens commented Feb 24, 2020 • edited

tobiasschweizer commented Mar 9, 2020

tobiasschweizer left a comment

Choose a reason for hiding this comment

tobiasschweizer commented Mar 10, 2020

tobiasschweizer commented Mar 11, 2020

tobiasschweizer Mar 11, 2020

Choose a reason for hiding this comment

flavens Mar 11, 2020

Choose a reason for hiding this comment

tobiasschweizer Mar 11, 2020

Choose a reason for hiding this comment

tobiasschweizer left a comment

Choose a reason for hiding this comment

flavens commented Mar 11, 2020

tobiasschweizer commented Mar 11, 2020

tobiasschweizer commented Mar 11, 2020

flavens commented Feb 24, 2020 •

edited