Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(display-edit): disable delete depending on cardinality (DSP-1814) #329

Merged
merged 4 commits into from Aug 12, 2021
Merged

feat(display-edit): disable delete depending on cardinality (DSP-1814) #329

merged 4 commits into from Aug 12, 2021

Commits on Aug 11, 2021

  1. feat(display-edit): do not allow user to delete a value if the proper… 

    …ty's cardinality does now allow it
    @mdelez
    mdelez committed Aug 11, 2021
    Copy the full SHA
    183635e View commit details
    Browse the repository at this point in the history

  2. fix: makes unit tests happy

    @mdelez
    mdelez committed Aug 11, 2021
    Copy the full SHA
    2424298 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. feat(display-edit): disables delete button instead of not showing it.… 

    … Also adds a tooltip explaining why a value cannot be deleted.
    @mdelez
    mdelez committed Aug 12, 2021
    Copy the full SHA
    4cf5f57 View commit details
    Browse the repository at this point in the history

  2. test(display-edit): adds test to check if disabling the delete button… 

    … works as expected
    @mdelez
    mdelez committed Aug 12, 2021
    Copy the full SHA
    3bf7202 View commit details
    Browse the repository at this point in the history