Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump dsp-js to latest version (DSP-1825) #322

Merged
merged 8 commits into from Jul 29, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Jul 28, 2021

resolves DSP-1825

and bump angular packages to the same version as we use in DSP-APP

@kilchenmann kilchenmann changed the title refactor(session)!: jwt is no longer relevant in the local storage chore(deps): bump dsp-js to latest version (DSP-1825) Jul 29, 2021
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Jul 29, 2021

Btw I thought we can get rid of the jwt in our local storage session object (s. a38a4ea) because the DSP-API requests are working with the cookie now. But unfortunately it's still needed for the sipi uploads (described here: https://docs.dasch.swiss/DSP-API/03-apis/api-v2/editing-values/#upload-files-to-sipi). So, we still need the access to it
and we have to keep the jwt info in our session object.

@kilchenmann kilchenmann self-assigned this Jul 29, 2021
@kilchenmann kilchenmann added chore Maintenance and build tasks dependencies labels Jul 29, 2021
@kilchenmann kilchenmann requested a review from mdelez July 29, 2021 07:34
@kilchenmann kilchenmann merged commit 4e8be74 into main Jul 29, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1825-bump-dsp-js branch July 29, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance and build tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants