New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(advanced search): try to reuse resource and property selection (DSP-1587) #290
Merged
Merged
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
177b410
feat(advanced search): try to reuse resource and property selection
8eaf7ef
feat(advanced search): restrict resource classes by linking property'…
203c06d
feat(advanced search): restrict resource classes by linking property'…
8f31bdb
feat(advanced search): make new parent component for resource and pro…
ed398f5
feat(advanced search): move new parent component into lib
9118503
feat(advanced search): use new component in advanced search form
85fefe9
Merge branch 'main' into wip/dsp-1587-search-linked-res
tobiasschweizer 86beef7
test(advanced search): adapt tests (ongoing)
5565abc
test(advanced search): adapt tests (ongoing)
3559f1b
test(advanced search): adapt tests (ongoing)
0ee6604
fix(dev build): remove exports from module
9901371
test(advanced search): adapt tests (ongoing)
e5eb3a1
test(advanced search): adapt tests (ongoing)
ab6a580
test(advanced search): adapt tests (ongoing)
25659f2
test(advanced search): adapt tests (ongoing)
93a85c5
refactor(advanced search): start from validation on AfterViewChecked
99bc16c
test(advanced search): fix e2e tests (ongoing)
a4b2a70
test(advanced search): fix e2e tests (ongoing)
e7f00ec
test(advanced search): do not install specific version of webdriver
7d66e2c
refactor(advanced search): move CSS
522191b
test(advanced search): simplify spec
7e21377
test(advanced search): simplify spec
cde4769
test(advanced search): simplify spec
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 0 additions & 9 deletions
9
projects/dsp-ui/src/lib/search/advanced-search/advanced-search.component.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1 @@ | ||
.select-resource-class { | ||
margin-left: 8px; | ||
} | ||
.select-property { | ||
margin-left: 16px; | ||
|
||
.property-button { | ||
margin: 0 12px 64px 0; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdelez I had to add this workaround because the existing instance always returned the old value for the state of the disabled prop.
I believe that we had a similar problem once but there the element was recreated in the DOM which is not the case here. Fishing in the dark here ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah from what I can remember, it won't update automatically if the value changes but I think you can reuse the same variable, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good point. I think. I could even avoid using a variable in the first place, see 7e21377
This failed locally, let's see how it behaves here.