Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(viewer): set correct rgba value (DSP-1588) #288

Merged
merged 1 commit into from Apr 30, 2021
Merged

fix(viewer): set correct rgba value (DSP-1588) #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/dsp-ui/src/lib/viewer/values/color-value/color-value.component.scss
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
}

.color-preview {
border: 1px solid rgba(33,33,33.5);
border: 1px solid rgba(33,33,33,.5);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.5 or 0.5??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, in scss we don't need a leading 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/sds/scss-lint/blob/master/lib/scss_lint/linter/README.md#leadingzero

border-radius: 4px;
padding: 3px 12px;
margin: 6px 0;
Expand Down