Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Value Form Control Name (DSP-1186) #250

Merged
merged 1 commit into from Jan 4, 2021
Merged

fix: Value Form Control Name (DSP-1186) #250

merged 1 commit into from Jan 4, 2021

Conversation

tobiasschweizer
Copy link
Contributor

resolves DSP-1186

@tobiasschweizer tobiasschweizer self-assigned this Jan 4, 2021
@tobiasschweizer tobiasschweizer added the bug Something isn't working label Jan 4, 2021
@tobiasschweizer
Copy link
Contributor Author

@mdelez We missed this one in #250.

mdelez
mdelez approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find :) searching for "this.form.controls" returns some results but I think they're okay

@tobiasschweizer
Copy link
Contributor Author

Nice find :) searching for "this.form.controls" returns some results but I think they're okay

I got some results for StringLiteralInputComponent and SearchListValueComponent, and these were not affected by #250

@tobiasschweizer tobiasschweizer merged commit 3098bfa into main Jan 4, 2021
@tobiasschweizer tobiasschweizer deleted the wip/1186-list-value branch January 4, 2021 12:49
@kilchenmann kilchenmann changed the title Fix Value Form Control Name fix: Value Form Control Name (DSP-1186) Jan 9, 2021
@kilchenmann kilchenmann mentioned this pull request Jan 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

Assignees

@tobiasschweizer tobiasschweizer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobiasschweizer @mdelez