Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSP-474 Create custom Harness for select ontology comp. #124

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

DSP-474 Create custom Harness for select ontology comp. #124

wants to merge 19 commits into from

Conversation

tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Jul 13, 2020 •
edited

@tobiasschweizer tobiasschweizer self-assigned this Jul 13, 2020
@tobiasschweizer
Copy link
Contributor Author

tobiasschweizer commented Jul 14, 2020 •
edited

5546faa adds the path config to protractor.conf.js so that the lib can be accessed (imported) in the e2e spec. I got the solution from nrwl/nx#263 (comment).

However, there is still a problem with the window object. When importing from @dasch-swiss/dsp-ui, jsonld is processed by ts-node. This throws an error because the window object is accessed, but not set in the node env:

E/launcher - Error: ReferenceError: window is not defined

@tobiasschweizer tobiasschweizer mentioned this pull request Jul 17, 2020
Open
@kilchenmann kilchenmann changed the base branch from master to main October 29, 2020 16:51
@kilchenmann kilchenmann changed the title Create custom Harness for select ontology comp. DSP-474 Create custom Harness for select ontology comp. Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tobiasschweizer tobiasschweizer

Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tobiasschweizer