Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: display-edit dev build errors #106

Merged
merged 9 commits into from Jun 15, 2020
Merged

FIX: display-edit dev build errors #106

merged 9 commits into from Jun 15, 2020

Commits on Jun 11, 2020

  1. refactor (display-edit): first not-so-elegant way of fixing dev build… 

    … errors
    @mdelez
    mdelez committed Jun 11, 2020
    Copy the full SHA
    2ea88b6 View commit details
    Browse the repository at this point in the history

  2. fix (display-edit): fixed a bug I introduced while fixing another bug

    @mdelez
    mdelez committed Jun 11, 2020
    Copy the full SHA
    ecd48c4 View commit details
    Browse the repository at this point in the history

  3. tests (operations): add assertions to display edit comp.

    Tobias Schweizer committed Jun 11, 2020
    Copy the full SHA
    3d3a0c5 View commit details
    Browse the repository at this point in the history

  4. formatting

    @mdelez
    mdelez committed Jun 11, 2020
    Copy the full SHA
    ff8561d View commit details
    Browse the repository at this point in the history

  5. Revert "refactor (display-edit): first not-so-elegant way of fixing d… 

    …ev build errors"

This reverts commit 2ea88b6.

# Conflicts:
#	projects/dsp-ui/src/lib/viewer/operations/display-edit/display-edit.component.ts
    @mdelez
    mdelez committed Jun 11, 2020
    Copy the full SHA
    184194d View commit details
    Browse the repository at this point in the history

  6. revert (display-edit): revert to original logic

    @mdelez
    mdelez committed Jun 11, 2020
    Copy the full SHA
    61ad3d3 View commit details
    Browse the repository at this point in the history

  7. fix (display-edit): fixed incorrect member name

    @mdelez
    mdelez committed Jun 11, 2020
    Copy the full SHA
    2f6f721 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. fix (tests): display-edit unit tests now check for an instance of the… 

    … appropriate readvalue. Also added some missing values
    @mdelez
    mdelez committed Jun 12, 2020
    Copy the full SHA
    c029d91 View commit details
    Browse the repository at this point in the history

  2. reworded a comment

    @mdelez
    mdelez committed Jun 12, 2020
    Copy the full SHA
    2a89cfb View commit details
    Browse the repository at this point in the history