New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(advanced search): try to reuse resource and property selection (DSP-1587) #290
Conversation
…s object constraint
…s object constraint
e2e/src/app.e2e-spec.ts
Outdated
|
||
const input = await loader.getHarness(MatInputHarness); | ||
|
||
await input.setValue('1'); | ||
|
||
expect(await submitButton.isDisabled()).toBe(false); | ||
const submitButton5 = await page.getAdvancedSearchSubmitButton(loader); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdelez I had to add this workaround because the existing instance always returned the old value for the state of the disabled prop.
I believe that we had a similar problem once but there the element was recreated in the DOM which is not the case here. Fishing in the dark here ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah from what I can remember, it won't update automatically if the value changes but I think you can reuse the same variable, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but I think you can reuse the same variable, no?
Yes, good point. I think. I could even avoid using a variable in the first place, see 7e21377
This failed locally, let's see how it behaves here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e/src/app.e2e-spec.ts
Outdated
|
||
const input = await loader.getHarness(MatInputHarness); | ||
|
||
await input.setValue('1'); | ||
|
||
expect(await submitButton.isDisabled()).toBe(false); | ||
const submitButton5 = await page.getAdvancedSearchSubmitButton(loader); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah from what I can remember, it won't update automatically if the value changes but I think you can reuse the same variable, no?
Right :) One is for the Boolean value and one is for the sort criterion. There is even an old task for this: https://dasch.myjetbrains.com/youtrack/issue/DSP-354 |
ah, I missed that :) |
maybe I should actually do this task :-) |
resolves DSP-1587
I decided to do this task in two steps: