Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: formal compliance checks of Excel (shape only) (DEV-3544) #930

Merged
merged 52 commits into from Apr 29, 2024
Merged

feat: formal compliance checks of Excel (shape only) (DEV-3544) #930

merged 52 commits into from Apr 29, 2024

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

@Nora-Olivia-Ammann Nora-Olivia-Ammann commented Apr 25, 2024 •
edited by jnussbaum

  • DF: at least two rows: list name and one node
  • Columns: cols that do not fit the expected format: print a warning that these will not be included
  • Columns: one "lang_list", at least one "lang_num"
  • Columns: in each hierarchy group (eg. "1_en", "1_de"), all languages used elsewhere must be present

@Nora-Olivia-Ammann
chore: delete tests (#903)
e743ec0
@Nora-Olivia-Ammann
feat: add models (DEV-3464) (#904)
25d5647
@Nora-Olivia-Ammann
new lists
1fd0295
@Nora-Olivia-Ammann
Merge branch 'wil/dev-3462-excel2json-lists-feature-branch' into wip/d…
0f93e7d 
…ev-3467-nodes-from-df
@Nora-Olivia-Ammann
get language for id
6d56e72
@Nora-Olivia-Ammann
Merge branch 'wip/dev-3467-nodes-from-df' of https://github.com/dasch…
8bccf17 
…-swiss/dsp-tools into wip/dev-3467-nodes-from-df
@Nora-Olivia-Ammann
Merge branch 'wip/dev-3462-new-lists-section-feature-branch' into wip/d…
e4c530d 
…ev-3467-nodes-from-df
@Nora-Olivia-Ammann
Update test_models_list_node.py
926314f
@Nora-Olivia-Ammann
add old test data
c69c310
@Nora-Olivia-Ammann
Update new_lists.py
09e9a05
@Nora-Olivia-Ammann
Update new_lists.py
e7ea8d7
@Nora-Olivia-Ammann
get labels, langs, columns
b7e76dd
@Nora-Olivia-Ammann
make one node
072a873
@Nora-Olivia-Ammann
change name listProblem
cb55ed2
@Nora-Olivia-Ammann
fill parent id
ef84a4f
@Nora-Olivia-Ammann
Merge branch 'wip/dev-3462-new-lists-section-feature-branch' into wip/d…
75bc40c 
…ev-3467-nodes-from-df
@Nora-Olivia-Ammann
handle ids
19dad1b
@Nora-Olivia-Ammann
Update test_lists.py
7ca52f7
@Nora-Olivia-Ammann
make list
a9cee1b
@Nora-Olivia-Ammann
fix tests
551b549
@Nora-Olivia-Ammann
fix typing
ebf34a0
@Nora-Olivia-Ammann
linting
b95a6d5
@Nora-Olivia-Ammann
fix tests
48574ef
@Nora-Olivia-Ammann
Update new_lists.py
1d54c1f
@Nora-Olivia-Ammann
Merge branch 'wip/dev-3462-new-lists-section-feature-branch' into wip/d…
da562b0 
…ev-3467-nodes-from-df
@Nora-Olivia-Ammann
nodes create
69866fe
@Nora-Olivia-Ammann
add to parents
ba1d275
@Nora-Olivia-Ammann
test make list
9fb60d9
@Nora-Olivia-Ammann
compliance files
a6c8761
@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Apr 25, 2024
@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the base branch from main to wip/dev-3462-new-lists-section-feature-branch April 25, 2024 13:39
Nora-Olivia-Ammann and others added 20 commits April 25, 2024 16:11
@Nora-Olivia-Ammann
change names
aa0bbcb
@jnussbaum
pair programming
7583738
@Nora-Olivia-Ammann
list compliance tests
2f3912e
@Nora-Olivia-Ammann
fixes
878794a
@Nora-Olivia-Ammann
Update new_lists.py
20203f7
@Nora-Olivia-Ammann
Update list_node.py
6ca883a
@Nora-Olivia-Ammann
Merge branch 'refs/heads/wip/dev-3467-nodes-from-df' into wip/dev-3544-…
9511542 
…lists-compliance-checks
@Nora-Olivia-Ammann
Merge branch 'wip/dev-3462-new-lists-section-feature-branch' into wip/d…
90a5750 
…ev-3544-lists-compliance-checks
@Nora-Olivia-Ammann
Merge branch 'wip/dev-3544-lists-compliance-checks' of https://github…
2646acd 
….com/dasch-swiss/dsp-tools into wip/dev-3544-lists-compliance-checks
@Nora-Olivia-Ammann
Update custom_warnings.py
e6972e4
@Nora-Olivia-Ammann
Update test_lists_compliance_checks.py
b361b02
@Nora-Olivia-Ammann
Update input_error.py
9b6825c
@Nora-Olivia-Ammann
Create lists.xlsx
ec7e238
@Nora-Olivia-Ammann
Update test_lists_compliance_checks.py
4ce73b6
@Nora-Olivia-Ammann
formal compliance check
e163582
@Nora-Olivia-Ammann
change output
6fbd9ad
@Nora-Olivia-Ammann
linting
0224630
@Nora-Olivia-Ammann
change location to fix integration test
f2869cb
@Nora-Olivia-Ammann
Update lists_compliance_checks.py
f6dd97b
@Nora-Olivia-Ammann
check for all translations present
61f9736
@jnussbaum jnussbaum changed the title feat: formal compliance checks format df (DEV-3544) feat: formal compliance checks of Excel (shape only) (DEV-3544) Apr 29, 2024
@jnussbaum jnussbaum mentioned this pull request Apr 29, 2024
Merged
jnussbaum
jnussbaum reviewed Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, and I like its architecture. The only thing I would definitively improve are some wordings of the error messages, see my comments.

src/dsp_tools/commands/excel2json/lists_compliance_checks.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/lists_compliance_checks.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/lists_compliance_checks.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/lists_compliance_checks.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/lists_compliance_checks.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/excel2json/models/input_error.py Outdated Show resolved Hide resolved
test/unittests/commands/excel2json/test_lists_compliance_checks.py Show resolved Hide resolved
test/unittests/commands/excel2json/test_lists_compliance_checks.py Outdated Show resolved Hide resolved
test/unittests/commands/excel2json/test_lists_compliance_checks.py Outdated Show resolved Hide resolved
test/unittests/commands/excel2json/test_lists_compliance_checks.py Outdated Show resolved Hide resolved
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit f70f48b into wip/dev-3462-new-lists-section-feature-branch Apr 29, 2024
8 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-3544-lists-compliance-checks branch April 29, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum left review comments

Assignees

@Nora-Olivia-Ammann Nora-Olivia-Ammann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nora-Olivia-Ammann @jnussbaum