feat: nodes from df (DEV-3467)

[Nora-Olivia-Ammann]

No description provided.

[linear]

DEV-3467 make nodes from df

[jnussbaum]

Here comes the first part of my comments. More is to follow...

[jnussbaum]

LGTM. I have a lot of suggestions that would make the code more understandable, but nothing severe that would prevent merging.

[Nora-Olivia-Ammann]

General comment: There is no place where users can put a comment for a list in the excel. I would ask RDU if they want to have it at all. Untill we cleared that up, I would leave it as it is easier to remove than add.

[BalduinLandolt]

General comment: There is no place where users can put a comment for a list in the excel. I would ask RDU if they want to have it at all. Untill we cleared that up, I would leave it as it is easier to remove than add.

Please try to keep the scope of your work to what is defined in the project, or check with PM/the project lead if you're unsure. Development is not the best time for discovering requirements. :)

[Nora-Olivia-Ammann]

ct, or check with PM/the project lead if you're unsure. Development is not the best time for discovering requirements. :)

Thanks, I'll ask Daniela, and I did not mean, to delete it from the json schema generally, just in the excel2json.

[BalduinLandolt]

ct, or check with PM/the project lead if you're unsure. Development is not the best time for discovering requirements. :)

Thanks, I'll ask Daniela, and I did not mean, to delete it from the json schema generally, just in the excel2json.

My plead was mainly towards simplicity/pragmatism: That's not your main focus here, so you shouldn't cause yourself too much work with it. Or in other words: If it's there, leave it there unless you have good reason to touch it (e.g. it causes you much extra work); and if it's not useable, that can be discussed some other time.