fix(xmlupload): improve URL recognition (DEV-1557) #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalduinLandolt
approved these changes
Dec 13, 2022
Comment on lines
+1345
to
1346
| except BaseError: | ||
| raise BaseError(f"Failed validation in resource '{calling_resource}', property '{name}': " |
There was a problem hiding this comment.
this seems like a bit of an anti-pattern: Raising an exception just to discard it again and raising the same exception again. If you moved the nicer error message to the UriValue object, you would not need to do the try or the raise here at all.
irinaschubert
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1557