Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(xmlupload): improve examples, add documentation of geometry-prop JSON format #240
docs(xmlupload): improve examples, add documentation of geometry-prop JSON format #240
Changes from 1 commit
b6fb6ca
2ba5979
81ea24a
a236953
94d8220
fa1230c
ec00596
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why it is important here to have a public and hidden colour value. This seems out of scope (to me) at this location in the documentation where it only explains how to use the color-prop property..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can understand your point, but it is very important for me to prevent users from creating a hidden value (
<color>#ff00ff</color>
). Unfortunately, the docs have only examples of hidden values until now. This is dangerous. So I wanted to find a way how I can grab the user's attention, and teach him this important difference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the long run, I could perhaps disallow the construct
<color>#ff00ff</color>
, and force the user to write<color permissions="None">#ff00ff</color>
. This would prevent mistakes, but it would be a breaking change.