New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xmlupload): enable migration of resource creation date (DEV-1402) #238
feat(xmlupload): enable migration of resource creation date (DEV-1402) #238
Conversation
@@ -63,7 +62,7 @@ def __str__(self) -> str: | |||
Convert to string | |||
:return: stringyfied error message | |||
""" | |||
return self._message + "\n\n" + format_exc() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a clue what format_exc()
was good for in the past, but I know that it causes problems. It was the source of this strange behaviour that I already had in the past: when a BaseError occurs while testing, Python prints an infinitely long stacktrace full of riddles, and then crashes.
I found out that I can just remove format_exc()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor improvement suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
resolves DEV-1402