Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix release-please (DEV-1396) #234

Merged
merged 1 commit into from Oct 7, 2022
Merged

chore: fix release-please (DEV-1396) #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 4 additions & 16 deletions .github/workflows/release-please.yml
View file
Open in desktop
@@ -1,30 +1,18 @@
name: Release-Please

# triggered when tests complete on main branch
# triggered when a PR is merged into main
on:
workflow_run:
workflows:
- "Test"
branches:
- main
pull_request:
types:
- completed
- closed

jobs:
refused:
# Do not release if tests failed
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'failure'}}
steps:
- id: refused_step
run: exit 1

Comment on lines -14 to -21
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no more tests on main, they cannot be checked. (And it's also not necessary, because a PR cannot be merged without sucessful tests).

release-please:
if: github.event.pull_request.merged == true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I follow the syntax of https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-workflow-when-a-pull-request-merges

# Automate releases with Conventional Commit Messages as Pull Requests are merged into "main" branch
name: Prepare next release
runs-on: ubuntu-latest
# release only if tests pass
if: ${{ github.event.workflow_run.conclusion == 'success'}}
steps:
- uses: GoogleCloudPlatform/release-please-action@v2
with:
Expand Down