Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tidy up excel2lists, excel2resources, excel2properties (DEV-1352) #229

Merged
merged 8 commits into from Sep 19, 2022
Merged

chore: tidy up excel2lists, excel2resources, excel2properties (DEV-1352) #229

merged 8 commits into from Sep 19, 2022

Commits on Sep 16, 2022

  1. edit

    @jnussbaum
    jnussbaum committed Sep 16, 2022
    Copy the full SHA
    46c5ce7 View commit details
    Browse the repository at this point in the history

  2. fix openpyxl type annotations

    @jnussbaum
    jnussbaum committed Sep 16, 2022
    Copy the full SHA
    76a78c3 View commit details
    Browse the repository at this point in the history

  3. improve unittests

    @jnussbaum
    jnussbaum committed Sep 16, 2022
    Copy the full SHA
    794ec99 View commit details
    Browse the repository at this point in the history

  4. improve unittests

    @jnussbaum
    jnussbaum committed Sep 16, 2022
    Copy the full SHA
    7b63827 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. adapt output format: return and save always as list[dict[str, Any]]

    @jnussbaum
    jnussbaum committed Sep 19, 2022
    Copy the full SHA
    73782f3 View commit details
    Browse the repository at this point in the history

  2. fix e2e test

    @jnussbaum
    jnussbaum committed Sep 19, 2022
    Copy the full SHA
    f4b3a32 View commit details
    Browse the repository at this point in the history

  3. adapt reviewer's feedback

    @jnussbaum
    jnussbaum committed Sep 19, 2022
    Copy the full SHA
    46ababa View commit details
    Browse the repository at this point in the history

  4. fix

    @jnussbaum
    jnussbaum committed Sep 19, 2022
    Copy the full SHA
    867f74b View commit details
    Browse the repository at this point in the history