Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(excel2resources, excel2properties): cover all cases (DEV-1040) #201

Merged
merged 28 commits into from Jun 23, 2022
Merged

fix(excel2resources, excel2properties): cover all cases (DEV-1040) #201

merged 28 commits into from Jun 23, 2022

Commits on Jun 15, 2022

  1. fix bugs 

    make more robust
    @jnussbaum
    jnussbaum committed Jun 15, 2022
    Copy the full SHA
    78f2a3f View commit details
    Browse the repository at this point in the history

  2. PR-title: allow commas and numbers in scope

    @jnussbaum
    jnussbaum committed Jun 15, 2022
    Copy the full SHA
    fee1074 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. fix DeprecationWarning: The metaschema specified by $schema was not f… 

    …ound. Using the latest draft to validate, but this will raise an error in the future.
    @jnussbaum
    jnussbaum committed Jun 16, 2022
    Copy the full SHA
    ae8cd88 View commit details
    Browse the repository at this point in the history

  2. allow multiple superclasses for properties

    @jnussbaum
    jnussbaum committed Jun 16, 2022
    Copy the full SHA
    f9eac36 View commit details
    Browse the repository at this point in the history

  3. remove old entry from MANIFEST.in (forgotten in an older PR)

    @jnussbaum
    jnussbaum committed Jun 16, 2022
    Copy the full SHA
    397cdd7 View commit details
    Browse the repository at this point in the history

  4. - cover more cases in the test data 

     - make script more robust
 - add column 'gui_attributes' to template
 - update docs
 - add unit tests for excel2properties
    @jnussbaum
    jnussbaum committed Jun 16, 2022
    Copy the full SHA
    93eb58f View commit details
    Browse the repository at this point in the history

  5. replace the too generic "Exception" by "ValueError"

    @jnussbaum
    jnussbaum committed Jun 16, 2022
    Copy the full SHA
    5d8b6da View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. improve checks if row is non-empty 

    allow multiple superclasses of resources
    @jnussbaum
    jnussbaum committed Jun 20, 2022
    Copy the full SHA
    a1fe43a View commit details
    Browse the repository at this point in the history

  2. unittests: check contents of outfile, not only if it exists 

    testdata: include more cases
    @jnussbaum
    jnussbaum committed Jun 20, 2022
    Copy the full SHA
    e0249db View commit details
    Browse the repository at this point in the history

  3. add Romansh to docs, testdata, and templates

    @jnussbaum
    jnussbaum committed Jun 20, 2022
    Copy the full SHA
    606a921 View commit details
    Browse the repository at this point in the history

  4. move pandas from dev-packages to packages

    @jnussbaum
    jnussbaum committed Jun 20, 2022
    Copy the full SHA
    44b951a View commit details
    Browse the repository at this point in the history

  5. include äöü

    @jnussbaum
    jnussbaum committed Jun 20, 2022
    Copy the full SHA
    6bfeb1b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into wip/dev-1040-improve-excel2resources-excel2p… 

    …roperties
    @jnussbaum
    jnussbaum committed Jun 20, 2022
    Copy the full SHA
    66fb7fc View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. improve docs

    @jnussbaum
    jnussbaum committed Jun 21, 2022
    Copy the full SHA
    12985de View commit details
    Browse the repository at this point in the history

  2. refactor tests

    @jnussbaum
    jnussbaum committed Jun 21, 2022
    Copy the full SHA
    6bb6917 View commit details
    Browse the repository at this point in the history

  3. remove superfluous e2e tests

    @jnussbaum
    jnussbaum committed Jun 21, 2022
    Copy the full SHA
    a2553cb View commit details
    Browse the repository at this point in the history

  4. improve test data

    @jnussbaum
    jnussbaum committed Jun 21, 2022
    Copy the full SHA
    2579d1c View commit details
    Browse the repository at this point in the history

  5. use pandas instead of openpyxl

    @jnussbaum
    jnussbaum committed Jun 21, 2022
    Copy the full SHA
    82c1708 View commit details
    Browse the repository at this point in the history

  6. move pandas from dev-packages to packages (also in requirements.txt a… 

    …nd dev-requirements.txt)
    @jnussbaum
    jnussbaum committed Jun 21, 2022
    Copy the full SHA
    b8a71c7 View commit details
    Browse the repository at this point in the history

  7. reduce number of code smells

    @jnussbaum
    jnussbaum committed Jun 21, 2022
    Copy the full SHA
    4fc05ab View commit details
    Browse the repository at this point in the history

  8. apply reviewer's feedback

    @jnussbaum
    jnussbaum committed Jun 21, 2022
    Copy the full SHA
    9364036 View commit details
    Browse the repository at this point in the history

  9. harmonize single quotes/double quotes

    @jnussbaum
    jnussbaum committed Jun 21, 2022
    Copy the full SHA
    2512729 View commit details
    Browse the repository at this point in the history

  10. break too long lines

    @jnussbaum
    jnussbaum committed Jun 21, 2022
    Copy the full SHA
    998909f View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. prevent empty labels or comments 

    include more special characters
    @jnussbaum
    jnussbaum committed Jun 22, 2022
    Copy the full SHA
    5443d61 View commit details
    Browse the repository at this point in the history

  2. shorten testdata files 

    hardcode expectations
    @jnussbaum
    jnussbaum committed Jun 22, 2022
    Copy the full SHA
    8e4ca89 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. add a unit test

    @jnussbaum
    jnussbaum committed Jun 23, 2022
    Copy the full SHA
    cb3933c View commit details
    Browse the repository at this point in the history

  2. reduce number of code smells

    @jnussbaum
    jnussbaum committed Jun 23, 2022
    Copy the full SHA
    aa25c88 View commit details
    Browse the repository at this point in the history

  3. - restore test_excel_to_json_resources() and test_excel_to_json_prop… 

    …erties()

 - delete test_validate_ontology()
test_tools.py is now a complete collection of all dsp-tools subcommands
    @jnussbaum
    jnussbaum committed Jun 23, 2022
    Copy the full SHA
    8b77cce View commit details
    Browse the repository at this point in the history