Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: excel to json list (DEV-431) #155

Merged
merged 18 commits into from Feb 17, 2022
Merged

refactor: excel to json list (DEV-431) #155

merged 18 commits into from Feb 17, 2022

Commits on Jan 28, 2022

  1. Don't open the file each time in the recursive function get_values_fr… 

    …om_excel()
    @jnussbaum
    jnussbaum committed Jan 28, 2022
    Copy the full SHA
    92d6d4f View commit details
    Browse the repository at this point in the history

  2. instead of side effects, all methods should return the result they co… 

    …mputed
    @jnussbaum
    jnussbaum committed Jan 28, 2022
    Copy the full SHA
    47ed29b View commit details
    Browse the repository at this point in the history

  3. - make code more understandable by improving the logic 

     - improve docstrings and annotations
    @jnussbaum
    jnussbaum committed Jan 28, 2022
    Copy the full SHA
    927d6bf View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. improve docstrings and annotations

    @jnussbaum
    jnussbaum committed Jan 31, 2022
    Copy the full SHA
    2201182 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. - various style/annotation improvements 

     - remove side-effect of get_values_from_excel by making a copy of parentnode before returning it
    @jnussbaum
    jnussbaum committed Feb 11, 2022
    Copy the full SHA
    cdec1c4 View commit details
    Browse the repository at this point in the history

  2. - correct mistake in logic 

     - improve error message output
    @jnussbaum
    jnussbaum committed Feb 11, 2022
    Copy the full SHA
    76bb885 View commit details
    Browse the repository at this point in the history

  3. - reconstruct the side-effect from before

    @jnussbaum
    jnussbaum committed Feb 11, 2022
    Copy the full SHA
    897a4f5 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. strip strings

    @jnussbaum
    jnussbaum committed Feb 14, 2022
    Copy the full SHA
    367e3bf View commit details
    Browse the repository at this point in the history

  2. adapt 'expand_all_lists.py' to the refactorings

    @jnussbaum
    jnussbaum committed Feb 14, 2022
    Copy the full SHA
    9fb5972 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into wip/dev-431-refactor-excel-to-json-list

    @jnussbaum
    jnussbaum committed Feb 14, 2022
    Copy the full SHA
    64aa62d View commit details
    Browse the repository at this point in the history

  4. elminate little bug

    @jnussbaum
    jnussbaum committed Feb 14, 2022
    Copy the full SHA
    b4afc09 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/wip/dev-431-refactor-excel-to-js… 

    …on-list' into wip/dev-431-refactor-excel-to-json-list
    @jnussbaum
    jnussbaum committed Feb 14, 2022
    Copy the full SHA
    1f61853 View commit details
    Browse the repository at this point in the history

  6. introduce the side effect again

    @jnussbaum
    jnussbaum committed Feb 14, 2022
    Copy the full SHA
    693eb11 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. rename variable 

    Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
    @jnussbaum
    jnussbaum and irinaschubert committed Feb 17, 2022
    Copy the full SHA
    88bca19 View commit details
    Browse the repository at this point in the history

  2. correct previous error

    @jnussbaum
    jnussbaum committed Feb 17, 2022
    Copy the full SHA
    adb66c2 View commit details
    Browse the repository at this point in the history

  3. improvements suggested by reviewer 

    Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
    @jnussbaum
    jnussbaum and irinaschubert committed Feb 17, 2022
    Copy the full SHA
    15e97a6 View commit details
    Browse the repository at this point in the history

  4. implement reviewer's feedback

    @jnussbaum
    jnussbaum committed Feb 17, 2022
    Copy the full SHA
    555ebe8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into wip/dev-431-refactor-excel-to-json-list

    @jnussbaum
    jnussbaum committed Feb 17, 2022
    Copy the full SHA
    0480f16 View commit details
    Browse the repository at this point in the history