fix(create-ontology): within an ontology, references to the ontology itself are not possible (DEV-135) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalduinLandolt
changed the title
irinaschubert
approved these changes
Nov 30, 2021
knora/dsplib/models/helpers.py
Outdated
| for prefix, onto in context.items(): | ||
| self._context[prefix] = OntoInfo(onto.removesuffix('#'), onto.endswith('#')) | ||
|
|
||
| # we always want the base ontologies/prefixes included in the context |
There was a problem hiding this comment.
I'm not very fond of these "we" comments. Maybe it can be changed to somewhat more neutral?
There was a problem hiding this comment.
you're right
knora/dsplib/models/helpers.py
Outdated
| if not self._context.get(k): | ||
| self._context[k] = v | ||
|
|
||
| # we always want the DSP-API ontologies/prefixes included in the context |
There was a problem hiding this comment.
I'm not very fond of these "we" comments. Maybe it can be changed to somewhat more neutral?
|
Kudos, SonarCloud Quality Gate passed!
|
irinaschubert
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-135
resolves DEV-278