Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontologies-endpoint): updateOntology method (DSP-1358) #329

Merged
merged 13 commits into from Mar 17, 2021

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Mar 1, 2021

resolves DSP-1358

@mdelez mdelez added the enhancement Improve existing code or new feature label Mar 1, 2021
@mdelez mdelez self-assigned this Mar 1, 2021
@mdelez
Copy link
Collaborator Author

mdelez commented Mar 11, 2021

e2e tests on github-ci require this PR dasch-swiss/dsp-api#1826. Waiting on a new DSP-API release which contains this PR.

@mdelez mdelez requested a review from kilchenmann March 12, 2021 09:21
@kilchenmann
Copy link
Contributor

kilchenmann commented Mar 12, 2021

I will test this PR in my DSP-APP "update ontology branch"

@kilchenmann
Copy link
Contributor

@mdelez comment is still missing in CreateOntology object. Could you add the following lines to it:

    @JsonProperty(Constants.Comment, String)
    comment: string = "";

@kilchenmann
Copy link
Contributor

@mdelez I saw you updated OntologyMetadata with comment but not the CreateOntology object. It's defined in task DSP-1357, but I think you can resolve it in the same PR

@mdelez
Copy link
Collaborator Author

mdelez commented Mar 12, 2021

@mdelez comment is still missing in CreateOntology object. Could you add the following lines to it:

    @JsonProperty(Constants.Comment, String)
    comment: string = "";

Sure thing! Should it be optional?

@kilchenmann
Copy link
Contributor

@mdelez comment is still missing in CreateOntology object. Could you add the following lines to it:

    @JsonProperty(Constants.Comment, String)
    comment: string = "";

Sure thing! Should it be optional?

Yes, I think it could be optional.

@mdelez
Copy link
Collaborator Author

mdelez commented Mar 12, 2021

Yes, I think it could be optional.

done in 4b95ebd :)

@mdelez mdelez merged commit a2d1beb into main Mar 17, 2021
@mdelez mdelez deleted the wip/DSP-1358-update-ontology branch March 17, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants