Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing decorator #173

Merged
merged 2 commits into from Apr 14, 2020
Merged

Conversation

tobiasschweizer
Copy link
Contributor

Fixes an issue caused by a missing decorator.

@tobiasschweizer tobiasschweizer added the bug Something isn't working label Apr 14, 2020
@tobiasschweizer tobiasschweizer self-assigned this Apr 14, 2020
@andreas-aeschlimann
Copy link
Contributor

Let's hope it's the only event of a missing decorator in the project. Otherwise it's good to go.

@tobiasschweizer
Copy link
Contributor Author

Let's hope it's the only event of a missing decorator in the project.

I think then more tests would fail.

@tobiasschweizer
Copy link
Contributor Author

Have you ever seen a thing like this

##[error]ERROR in node_modules/json2typescript/src/json2typescript/json-convert.d.ts(26,9): error TS1086: An accessor cannot be declared in an ambient context.
1656
##[error]node_modules/json2typescript/src/json2typescript/json-convert.d.ts(37,9): error TS1086: An accessor cannot be declared in an ambient context.
1657
Hash: b3c99c0b739debe23b87
1658
##[error]node_modules/json2typescript/src/json2typescript/json-convert.d.ts(57,9): error TS1086: An accessor cannot be declared in an ambient context.
1659
##[error]node_modules/json2typescript/src/json2typescript/json-convert.d.ts(68,9): error TS1086: An accessor cannot be declared in an ambient context.
1660
##[error]node_modules/json2typescript/src/json2typescript/json-convert.d.ts(80,9): error TS1086: An accessor cannot be declared in an ambient context.
1661
##[error]node_modules/json2typescript/src/json2typescript/json-convert.d.ts(87,9): error TS1086: An accessor cannot be declared in an ambient context.
1662
##[error]node_modules/json2typescript/src/json2typescript/json-convert.d.ts(105,9): error TS1086: An accessor cannot be declared in an ambient context.
1663
##[error]node_modules/json2typescript/src/json2typescript/json-convert.d.ts(115,9): error TS1086: An accessor cannot be declared in an ambient context.
1664
##[error]node_modules/json2typescript/src/json2typescript/json-convert.d.ts(131,9): error TS1086: An accessor cannot be declared in an ambient context.
1665
##[error]node_modules/json2typescript/src/json2typescript/json-convert.d.ts(140,9): error TS1086: An accessor cannot be declared in an ambient context.

@tobiasschweizer
Copy link
Contributor Author

looks like a compiler problem: storybookjs/storybook#9463

@andreas-aeschlimann
Copy link
Contributor

Yes:
appvision-gmbh/json2typescript#126

Upgrade to Angular 8 which supports TypeScript 3.5+ should solve the issue.

I will try to fix it in the d.ts files when I find out how.

@tobiasschweizer
Copy link
Contributor Author

Yes:
AppVision-GmbH/json2typescript#126

Upgrade to Angular 8 which supports TypeScript 3.5+ should solve the issue.

I will try to fix it in the d.ts files when I find out how.

I have already made a PR for the update to Angular 9: #172

For now, I have adapted package.json so that it does not update to json2typescript 1.3.0.

@tobiasschweizer tobiasschweizer merged commit 80eb89d into master Apr 14, 2020
@tobiasschweizer tobiasschweizer deleted the wip/dsp_160-missing-decorator branch April 14, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants