Test Framework: Do Not Check for Exact Number of Search Results in E2E Tests #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this PR has been merged, the JS lib tests will pass for knora-api. edit: the tests for dasch-swiss/dsp-api@e80bf52 can then be re-run |
benjamingeer
approved these changes
Apr 8, 2020
you mean we should run them against a specific release of knora-api and remove the setup from github-ci as it is now? |
Yes, exactly. |
Ok, let's do this once we have decided how to proceed with releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the assertions in the E2E tests so that search tests do not expect an exact number of results (see dasch-swiss/dsp-api#1615 (comment)). The data can always change in knora-api, but this is irrelevant to these tests. They just have to make sure that the result can be obtained and deserialized correctly.