Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ontologies displayed twice (DEV-1325) #832

Merged
merged 2 commits into from Sep 23, 2022
Merged

fix: Ontologies displayed twice (DEV-1325) #832

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f547259
fix: Fixed bug by checking duplicates in Ontology Component
EricSommerhalder Sep 22, 2022
b46e45e
fix: fixing auto imports and rename variables
EricSommerhalder Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/app/project/ontology/ontology.component.ts
View file
Open in desktop
Expand Up @@ -382,7 +382,26 @@ export class OntologyComponent implements OnInit {
(ontologies: ReadOntology[]) => {
// update current list of project ontologies
ontologies[ontologies.findIndex(onto => onto.id === ontology.id)] = ontology;
this._cache.set('currentProjectOntologies', ontologies);
// avoid duplicates
const uniqueOntologies: ReadOntology[] = [];
const uniqueIds: String[] = [];
for (const onto of ontologies){
if (uniqueIds.indexOf(onto.id) !== -1){
let oldOntoIndex: number;
uniqueOntologies.forEach((o, index) => {
if (o.id === onto.id) {
oldOntoIndex = index;
}
});
if (Object.keys(onto.properties).length > Object.keys(uniqueOntologies[oldOntoIndex].properties).length){ // new onto has more props -> replace
uniqueOntologies[oldOntoIndex] = onto;
}
} else {
uniqueIds.push(onto.id);
uniqueOntologies.push(onto);
}
}
this._cache.set('currentProjectOntologies', uniqueOntologies);
},
() => {} // don't log error to rollbar if 'currentProjectOntologies' does not exist in the cache
);
Expand Down