Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Onto editor 404 error (DEV-1355) #831

Merged
merged 4 commits into from Sep 23, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/app/app-routing.module.ts
Expand Up @@ -130,6 +130,11 @@ const routes: Routes = [
component: OntologyComponent,
canActivate: [AuthGuard]
},
{
path: 'ontology/:onto/editor/:view',
component: OntologyComponent,
canActivate: [AuthGuard]
},
{
path: 'ontology/:onto/:class',
component: OntologyClassInstanceComponent,
Expand Down
6 changes: 5 additions & 1 deletion src/app/project/ontology/ontology.component.ts
Expand Up @@ -618,7 +618,11 @@ export class OntologyComponent implements OnInit {
this._dspApiConnection.v2.onto.deleteResourceProperty(resProp).subscribe(
(response: OntologyMetadata) => {
this.loading = false;
this.resetOntology(this.ontologyIri);
// this.resetOntology(this.ontologyIri);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove it if not needed anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely, removed in 3b60ad2

// get the ontologies for this project
this.initOntologiesList();
// update the view of resource class or list of properties
this.initOntology(this.ontologyIri);
},
(error: ApiResponseError) => {
this._errorHandler.showMessage(error);
Expand Down
2 changes: 1 addition & 1 deletion src/app/project/project.component.ts
Expand Up @@ -218,7 +218,7 @@ export class ProjectComponent implements OnInit {
id = array[pos];
}
if (id) {
this._router.navigate([route, encodeURIComponent(id)], { relativeTo: this._route });
this._router.navigate([route, encodeURIComponent(id), 'editor', 'classes'], { relativeTo: this._route });
} else {
this._router.navigate([route], { relativeTo: this._route });
}
Expand Down