Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-value-as-string): links in text values (DEV-797) #718

Merged
merged 2 commits into from Apr 22, 2022
Merged

fix(text-value-as-string): links in text values (DEV-797) #718

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b47a959
fix(text-value-as-string): only use linkify pipe if the gui-element i…
mdelez Apr 22, 2022
dd18b9e
chore(text-value-as-string): remove 'this' from html
mdelez Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...space/resource/values/text-value/text-value-as-string/text-value-as-string.component.html
View file
Open in desktop
@@ -1,6 +1,6 @@
<span *ngIf="mode === 'read'; else showForm" class="read-mode-view">
<!-- TODO in DEV-797: appLinkify pipe should only be used if property's gui-element is not richt-text; I had the same issue in regions -->
<span class="rm-value text-value" [innerHtml]="valueFormControl.value | appLinkify" style="white-space: pre-wrap;"></span>
<!-- only use linkify pipe if property's gui-element is not richtext; I had the same issue in regions -->
<span class="rm-value text-value" [innerHtml]="this.guiElement === 'richText' ? this.valueFormControl.value : valueFormControl.value | appLinkify" style="white-space: pre-wrap;"></span>
<span class="rm-comment" *ngIf="shouldShowComment">{{commentFormControl.value}}</span>
</span>
<ng-template #showForm>
Expand Down