Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(help): refactor version number and fix dead link (DEV-678) #693

Merged
merged 4 commits into from Mar 23, 2022
Merged

fix(help): refactor version number and fix dead link (DEV-678) #693

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
466fd72
fix(help): resolve dead link
kilchenmann Mar 22, 2022
52ed4a7
fix(help): fix dead link to gh releases
kilchenmann Mar 22, 2022
bb94dfc
Merge branch 'main' into wip/DEV-678-refactor-version-number
kilchenmann Mar 22, 2022
bf2f089
Merge branch 'main' into wip/DEV-678-refactor-version-number
kilchenmann Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/app/main/help/help.component.ts
View file
Open in desktop
Expand Up @@ -59,7 +59,7 @@ export class HelpComponent implements OnInit {
{
title: 'DSP-API ',
text: 'Framework to store, share, and work with primary resources in the humanities.',
url: 'https://github.com/dasch-swiss/dsp-api/releases/tag/',
url: 'https://github.com/dasch-swiss/dsp-api/releases/tag/v',
urlText: 'Release notes'
},
{
Expand Down Expand Up @@ -111,15 +111,15 @@ export class HelpComponent implements OnInit {
this.apiVersion = response.body;

// set dsp-app version
this.tools[0].title += ' v' + this.appVersion;
this.tools[0].title += this.appVersion;
this.tools[0].url += this.appVersion;

// set dsp-api version
this.tools[1].title += this.apiVersion.webapi;
this.tools[1].url += this.apiVersion.webapi;

// set dsp-sipi version
this.tools[2].title += ' v' + this.apiVersion.sipi;
this.tools[2].title += this.apiVersion.sipi;
this.tools[2].url += this.apiVersion.sipi;
},
(error: ApiResponseError) => {
Expand Down