Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(links): trust external links (DSP-1904) #537

Merged
merged 1 commit into from Sep 17, 2021
Merged

fix(links): trust external links (DSP-1904) #537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/app/main/directive/external-links.directive.ts
View file
Open in desktop
@@ -1,5 +1,6 @@
import { isPlatformBrowser } from '@angular/common';
import { Directive, HostBinding, Inject, Input, OnChanges, PLATFORM_ID } from '@angular/core';
import { DomSanitizer, SafeUrl } from '@angular/platform-browser';

@Directive({
selector: 'a[href]'
Expand All @@ -9,14 +10,17 @@ export class ExternalLinksDirective implements OnChanges {
@Input() href: string;
@HostBinding('attr.rel') relAttr = '';
@HostBinding('attr.target') targetAttr = '';
@HostBinding('attr.href') hrefAttr = '';
@HostBinding('attr.href') hrefAttr: SafeUrl;
@HostBinding('class') class = 'external-link';

// to check if we are running on the server, give a token value
constructor(@Inject(PLATFORM_ID) private platformId: string) { }
constructor(
@Inject(PLATFORM_ID) private platformId: string,
private _sanitizer: DomSanitizer
) { }

ngOnChanges() {
this.hrefAttr = this.href;
this.hrefAttr = this._sanitizer.bypassSecurityTrustUrl(this.href);

if (this._isLinkExternal()) {
// makes sure that the new browser tab does not run on the same process and prevent it from accessing window.opener
Expand Down