New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve error handler and fix search results issue (DSP-1826 / DSP-1831) #493
chore: improve error handler and fix search results issue (DSP-1826 / DSP-1831) #493
Conversation
This code was already written in DSP-UI. No need here to rewrite
@@ -29,11 +28,9 @@ export class ResultsComponent { | |||
searchMode: 'fulltext' | 'gravsearch'; | |||
|
|||
// progress status | |||
loading = true; | |||
loading = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still needed? I don't think this variable is used anywhere now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, well seen 👍 no it's not needed anymore.
Removed in ed38403
Oh no, the title was wrong. This PR will not shown in the release notes |
resolves DSP-1831
resolves DSP-1826