New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ontology): check if an ontology, a class or a property can be deleted (DSP-1750) #457
Merged
Merged
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
57a6fe7
docs(ontology): fix 404 error on image
kilchenmann 2057aeb
chore(deps): bump dsp-js version to 2.4.0
kilchenmann 59a2a87
feat(ontology): disable delete class button
kilchenmann 3a06c6e
refactor(ontology): clean up code
kilchenmann 10fe80d
refactor(ontology): consistent submit button
kilchenmann 43b99e0
feat(ontology): disable delete ontology button
kilchenmann 6b7e75e
fix(ontology): use the right method
kilchenmann 43d9d59
Merge branch 'main' into wip/dsp-1623-check-edit-properties
kilchenmann e7f38c6
feat(ontology): ask if res class can be deleted
kilchenmann 95eca63
test(ontology): fix tests
kilchenmann ccb8ab4
test(ontology): bug fix in test
kilchenmann 62783b2
test(ontology): bug fix in test
kilchenmann 4ee9060
chore(ontology): undo previous changes
kilchenmann 2470269
test(ontology): fix the test
kilchenmann f207e89
test(ontology): run all the tests
kilchenmann 7f6e704
test(ontology): add test to new method
kilchenmann e6e928a
Merge branch 'main' into wip/dsp-1623-check-edit-properties
kilchenmann 4aa4b43
test(ontology): enable all tests
kilchenmann 6c87033
test(ontology): set correct test environment
kilchenmann 78fa92b
feat(ontology): check if prop can be deleted
kilchenmann 5db5353
test(ontology): enable all tests
kilchenmann 7eea77b
fix(ontology): propCanBeDeleted shouldn't be in the cardinality setup
kilchenmann File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
src/app/project/ontology/ontology-form/ontology-form.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this logic needs to be refactored. I can delete the property even though it says I can't. AS a side note, I think the delete icon should be the trash can for consistency reasons. The icon currently being used is normally used for "backspace".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved in 5db5353