Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(list-editor): delete list root node (DSP-1356) #386

Merged
merged 5 commits into from Feb 17, 2021
Merged

feat(list-editor): delete list root node (DSP-1356) #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8cfafe8
feat: adds support for deleting a root node if not in use
mdelez Feb 16, 2021
20de72a
feat: switches the buttons from using text to using mat-icons. Also a…
mdelez Feb 16, 2021
e7c22b6
test: starting point for unit tests
mdelez Feb 16, 2021
a4a19a9
test: adds unit tests for list component
mdelez Feb 17, 2021
a616e65
Merge branch 'main' into wip/DSP-1356-delete-root-node
mdelez Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/app/project/list/list.component.html
View file
Open in desktop
Expand Up @@ -66,9 +66,15 @@ <h2 class="mat-title">
<p class="mat-body" [matTooltip]="list.comments | dspStringifyStringLiteral" matTooltipPosition="above">
{{list.comments | dspStringifyStringLiteral | dspTruncate:64}}</p>
<span class="fill-remaining-space"></span>
<button mat-stroked-button
(click)="$event.stopPropagation(); openDialog('editListInfo', list.labels[0].value, list.id)">
Edit info
<button mat-button
(click)="$event.stopPropagation(); openDialog('editListInfo', list.labels[0].value, list.id)"
matTooltip="Edit info">
<mat-icon>edit</mat-icon>
</button>
<button mat-button class="delete"
(click)="$event.stopPropagation(); openDialog('deleteList', list.labels[0].value, list.id)"
matTooltip="Delete list">
<mat-icon>delete</mat-icon>
</button>
</mat-toolbar-row>
</mat-toolbar>
Expand Down
14 changes: 14 additions & 0 deletions src/app/project/list/list.component.scss
View file
Open in desktop
Expand Up @@ -16,3 +16,17 @@
min-width: 140px;
}
}

.list-editor {
mat-toolbar-row {
button {
margin: 0% 0.5%;
padding: 1%;
min-width: 6%;
border-radius: 40px;
}
button:hover {
background-color: #ebebeb;
}
}
}