refactor(project landing page): add interfaces for metadata object (DSP-1183) #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2021 23:17
…nd replace bracket notation with dot notation
flavens
reviewed
Jan 21, 2021
src/app/project/board/attribution-tab-view/attribution-tab-view.component.html
Outdated
Show resolved
Hide resolved
waychal
changed the title
mpro7
changed the title
flavens
approved these changes
Jan 21, 2021
mpro7
reviewed
Jan 21, 2021
src/app/project/board/attribution-tab-view/attribution-tab-view.component.ts
Show resolved
Hide resolved
| @@ -0,0 +1,123 @@ | |||
| /* Interface for url type */ | |||
There was a problem hiding this comment.
I would remove all comments for interfaces which are self-descriptive and leave only these which are not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1183
In this PR, we use interfaces to define metadata object.