refactor: remove unused code (#1586)

dasch-swiss · May 15, 2024 · 0b4b554 · 0b4b554
1 parent d4ea5fb
commit 0b4b554
Show file tree

Hide file tree

Showing 11 changed files with 39 additions and 156 deletions.
diff --git a/...p/project/ontology-classes/ontology-class-instance/ontology-class-instance.component.html b/...p/project/ontology-classes/ontology-class-instance/ontology-class-instance.component.html
@@ -10,10 +10,7 @@
     <as-split-area [size]="60" *ngIf="selectedResources?.count > 0" cdkScrollable>
       <div [ngSwitch]="viewMode">
         <!-- single resource view -->
-        <app-resource
-          *ngSwitchCase="'single'"
-          [resourceIri]="selectedResources.resInfo[0].id"
-          [splitSizeChanged]="splitSizeChanged"></app-resource>
+        <app-resource *ngSwitchCase="'single'" [resourceIri]="selectedResources.resInfo[0].id"></app-resource>
 
         <!-- intermediate view -->
         <app-intermediate

diff --git a/apps/dsp-app/src/app/workspace/comparison/comparison.component.html b/apps/dsp-app/src/app/workspace/comparison/comparison.component.html
@@ -2,17 +2,17 @@
   <as-split direction="vertical">
     <as-split-area>
       <!-- note: This part is repeating twice (not added as component) because angular-split
-                library does not support addition div inside as-split -->
+                      library does not support addition div inside as-split -->
       <as-split direction="horizontal" (dragEnd)="splitSizeChanged = $event">
         <as-split-area *ngFor="let res of topRow">
-          <app-resource [resourceIri]="res" [splitSizeChanged]="splitSizeChanged"></app-resource>
+          <app-resource [resourceIri]="res"></app-resource>
         </as-split-area>
       </as-split>
     </as-split-area>
     <as-split-area *ngIf="noOfResources > 3">
       <as-split direction="horizontal" (dragEnd)="splitSizeChanged = $event">
         <as-split-area *ngFor="let res of bottomRow">
-          <app-resource [resourceIri]="res" [splitSizeChanged]="splitSizeChanged"></app-resource>
+          <app-resource [resourceIri]="res"></app-resource>
         </as-split-area>
       </as-split>
     </as-split-area>

diff --git a/apps/dsp-app/src/app/workspace/resource/properties/resource-toolbar/resource-toolbar.ts b/apps/dsp-app/src/app/workspace/resource/properties/resource-toolbar/resource-toolbar.ts
@@ -1,14 +1,6 @@
-import {
-  ChangeDetectionStrategy,
-  ChangeDetectorRef,
-  Component,
-  EventEmitter,
-  Input,
-  OnInit,
-  Output,
-} from '@angular/core';
+import { ChangeDetectionStrategy, ChangeDetectorRef, Component, Input, OnInit } from '@angular/core';
 import { MatDialog } from '@angular/material/dialog';
-import { DeleteResourceResponse, PermissionUtil, ReadLinkValue, ReadProject, ReadValue } from '@dasch-swiss/dsp-js';
+import { DeleteResourceResponse, PermissionUtil, ReadLinkValue, ReadProject } from '@dasch-swiss/dsp-js';
 import { AdminProjectsApiService } from '@dasch-swiss/vre/open-api';
 import { DspResource, ResourceService } from '@dasch-swiss/vre/shared/app-common';
 import {
@@ -52,9 +44,6 @@ export class ResourceToolbarComponent implements OnInit {
 
   @Input() lastModificationDate: string;
 
-  @Output() regionChanged: EventEmitter<ReadValue> = new EventEmitter<ReadValue>();
-  @Output() regionDeleted: EventEmitter<void> = new EventEmitter<void>();
-
   userCanDelete: boolean;
   userCanEdit: boolean;
   canReadComments: boolean;
@@ -106,9 +95,6 @@ export class ResourceToolbarComponent implements OnInit {
       .pipe(filter(answer => !!answer))
       .subscribe(answer => {
         this._componentCommsService.emit(new EmitEvent(CommsEvents.resourceChanged));
-        if (this.isAnnotation) {
-          this.regionChanged.emit();
-        }
         this._cd.markForCheck();
       });
   }
@@ -154,10 +140,6 @@ export class ResourceToolbarComponent implements OnInit {
     const classId = this.resource.res.entityInfo.classes[this.resource.res.type]?.id;
     this._store.dispatch(new LoadClassItemsCountAction(ontologyIri, classId));
     this._componentCommsService.emit(new EmitEvent(CommsEvents.resourceDeleted));
-    // if it is an Annotation/Region which has been erases, we emit the
-    // regionChanged event, in order to refresh the page
-    this.regionDeleted.emit();
-
     this._cd.markForCheck();
   }
 }
diff --git a/apps/dsp-app/src/app/workspace/resource/representation/av-timeline/av-timeline.component.ts b/apps/dsp-app/src/app/workspace/resource/representation/av-timeline/av-timeline.component.ts
@@ -10,12 +10,12 @@ import {
   SimpleChange,
   ViewChild,
 } from '@angular/core';
-import { SplitSize } from '../../../results/results.component';
 
 export interface PointerValue {
   position: number;
   time: number;
 }
+
 /**
  * this component can be used in video and audio players
  */
@@ -40,9 +40,6 @@ export class AvTimelineComponent implements OnChanges {
   // disable in case of missing file
   @Input() disabled: boolean;
 
-  // split size changed
-  @Input() splitSizeChanged: SplitSize;
-
   // send click position to parent
   @Output() changed = new EventEmitter<number>();
 

diff --git a/apps/dsp-app/src/app/workspace/resource/representation/video/video.component.html b/apps/dsp-app/src/app/workspace/resource/representation/video/video.component.html
@@ -49,7 +49,6 @@
         [min]="0"
         [max]="duration"
         [resized]="cinemaMode"
-        [splitSizeChanged]="splitSizeChanged"
         (move)="updatePreview($event)"
         (mouseenter)="displayPreview(true)"
         (dimension)="timelineDimension = $event"

diff --git a/apps/dsp-app/src/app/workspace/resource/representation/video/video.component.ts b/apps/dsp-app/src/app/workspace/resource/representation/video/video.component.ts
@@ -27,7 +27,6 @@ import { DspApiConnectionToken } from '@dasch-swiss/vre/shared/app-config';
 import { NotificationService } from '@dasch-swiss/vre/shared/app-notification';
 import { mergeMap } from 'rxjs/operators';
 import { DialogComponent } from '../../../../main/dialog/dialog.component';
-import { SplitSize } from '../../../results/results.component';
 import {
   EmitEvent,
   Events,
@@ -51,8 +50,6 @@ export class VideoComponent implements OnChanges, AfterViewInit {
 
   @Input() parentResource: ReadResource;
 
-  @Input() splitSizeChanged: SplitSize;
-
   @Output() loaded = new EventEmitter<boolean>();
 
   @ViewChild('videoEle') videoEle: ElementRef;

diff --git a/apps/dsp-app/src/app/workspace/resource/resource.component.html b/apps/dsp-app/src/app/workspace/resource/resource.component.html
@@ -19,10 +19,7 @@
           [resource]="resource"
           [lastModificationDate]="resource.res.lastModificationDate"
           [adminPermissions]="isAdmin$ | async"
-          [showEditLabel]="false"
-          (regionChanged)="regionChanged.emit()"
-          (regionDeleted)="regionDeleted.emit()"></app-resource-toolbar>
-        <!-- TODO uncomment this on  top -->
+          [showEditLabel]="false"></app-resource-toolbar>
       </div>
       <div class="resource-label">
         <h4>{{ resource.res.label }}</h4>
@@ -37,7 +34,7 @@ <h4>{{ resource.res.label }}</h4>
       </div>
       <div class="infobar mat-caption" *ngIf="(project$ | async) as project">
         Resource of the project
-        <a class="link" [title]="project.longname" (click)="openProject(project)" (mouseover)="previewProject()">
+        <a class="link" [title]="project.longname" (click)="openProject(project)">
           <strong>{{ project?.shortname }}</strong></a
         ><span *ngIf="resourceAttachedUser || resource.res.creationDate"
           >, created
@@ -98,7 +95,6 @@ <h4>{{ resource.res.label }}</h4>
         *ngSwitchCase="representationConstants.movingImage"
         [src]="representationsToDisplay[0]"
         [parentResource]="resource.res"
-        [splitSizeChanged]="splitSizeChanged"
         (loaded)="representationLoaded($event)">
       </app-video>