Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove startup dependency on Sipi, remove checking iiif server available on startup #3218

Merged
merged 4 commits into from Apr 26, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Apr 25, 2024

  • Do not fail if IIIF server is not available at startup

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the title chore/remove checking iif server on startup chore: Remove startupdependency on Sipi, remove checking iiif server on startup Apr 25, 2024
@seakayone seakayone force-pushed the chore/remove-checking-iif-server-on-startup branch from e611b1b to e411161 Compare April 25, 2024 12:58
@seakayone seakayone changed the title chore: Remove startupdependency on Sipi, remove checking iiif server on startup chore: Remove startup dependency on Sipi, remove checking iiif server available on startup Apr 25, 2024
@seakayone seakayone marked this pull request as ready for review April 25, 2024 13:00
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you implementing this because this is not a continual health-check, but a one-off instead?

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@seakayone seakayone enabled auto-merge (squash) April 26, 2024 06:45
@seakayone
Copy link
Collaborator Author

Are you implementing this because this is not a continual health-check, but a one-off instead?

I don't think I would even want to have continuous health-check for Sipi. The dsp-api would mostly work without it; a minor set of functionality is of course degraded. Unlike if the database would be down, which is a far more crucial dependency.

@seakayone seakayone disabled auto-merge April 26, 2024 08:17
@seakayone seakayone enabled auto-merge (squash) April 26, 2024 08:27
@seakayone seakayone merged commit f1c99d2 into main Apr 26, 2024
12 checks passed
@seakayone seakayone deleted the chore/remove-checking-iif-server-on-startup branch April 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants